Changing orientation on the fly results into broken output

danielcrisp / angular-rangeslider

Simple directive that creates a range slider for Angular, styled to match Bootstrap-styled form elements

danielcrisp.github.io/angular-rangeslider/

MIT License

223 stars 122 forks source link

Changing orientation on the fly results into broken output #90

Closed stefanwalther closed 9 years ago

stefanwalther commented 9 years ago

Hi,

changing the orientation on the fly results into the following broken output.

angular-range-slider-broken

Tried to fix it by calling setMinMax at the end of attrs.$observe( 'orientation', function ( val ) { which results into a better state, but still with some weird stylings:

setminmax

Any idea how to solve that and what could be the reason?

Thx a lot in advance & regards Stefan

danielcrisp commented 9 years ago

Does your PR #89 fix this issue?

I'd imagine the problems are caused by the CSS top and left values not being cleaned properly. To be honest this is never a situation I envisaged so it doesn't actually support changing the orientation on the fly

stefanwalther commented 9 years ago

No, #89 does not fix the issue.

stefanwalther commented 9 years ago

@danielcrisp I have updated #89 and solved this issue, orientation can now be changed on the fly and is fully working. Some changes were necessary though.