danieldesira / DanielsConnect4

Connect4 implementation in TypeScript ported from JavaScript code written prior to 2013
GNU General Public License v2.0
0 stars 0 forks source link

UI Issues specific to 0.3 #39

Closed danieldesira closed 1 year ago

danieldesira commented 1 year ago

To be fixed by 0.3 release:

  1. Sometimes the player name dialog is triggered more than once in network play. We need to add a check that prevents this behaviour.
  2. To look into size of produced script. We might need to drop FontAwesome or choose files to include more selectively. If need be, it is okay to remove the effects for the icons.
danieldesira commented 1 year ago

branch: ui_bugs

danieldesira commented 1 year ago

Point 2 fully implemented. Please revert the change for point 1 and implement the following in the dialogs module:

  1. Prevent additional dialogs of the same kind from opening when a dialog is open.
  2. Add a Cancel button to input dialogs.
  3. Simplify validation by supporting required and aria-required.
  4. Set max-height for dialog and make content scrollable if exceeds the max height.
danieldesira commented 1 year ago

Only 2 issues are pending:

  1. Align OK and Cancel buttons on the same line.
  2. Update dialog input IDs to dialog-input-${color}.
danieldesira commented 1 year ago

Changes should be finalised