Closed danieldesira closed 9 months ago
Point 1 not to be implemented as it will be tackled on the server.
Point 2, 3 and 4 to be implemented in branch ui_bugs
.
To do:
Point 2 will also not be handled because it would actually make code more complex rather than helping to clean up. Indeed what can actually be done would be to throw an exception in authPost
rather than accept a handleError
callback and then we could handle errors using a try-catch block.
Moreover, regarding UI, we should respect dark themes by using the appropriate @media
rule in the CSS.
When these two are tackled, we can publish the changes.
The following issues to be sorted:
isGameInitialised
and check against it before setting any properties from theInitialMessage
model.getAuth
function to includehandleSuccess
callback parameter. We can also refactor bothgetAuth
andpostAuth
to accept an object as a parameter. (Create an interface and proceed.)(Beta)
tob
.