search

danieldeutsch / sacrerouge

SacreROUGE is a library dedicated to the use and development of text generation evaluation metrics with an emphasis on summarization.
Apache License 2.0
134 stars 11 forks source link

Allow complex types in `FromParams` #3

Closed danieldeutsch closed 4 years ago

danieldeutsch commented 4 years ago

Right now, FromParams only works with primitive arguments. It would be nice if it could be extended to work with parameters of type List[Registrable] in which each item in the list would be deserialized recursively.

The idea for FromParams comes from AllenNLP, so their implementation would be a good starting spot (although I don't think we quite need the complexity they have).