danieldeutsch / sacrerouge

SacreROUGE is a library dedicated to the use and development of text generation evaluation metrics with an emphasis on summarization.
Apache License 2.0
134 stars 11 forks source link

DecomposedRouge spacy model version is incorrect #68

Closed danieldeutsch closed 3 years ago

danieldeutsch commented 3 years ago

The spacy model version 2.2.5 is unable to be installed via the python -m spacy download command, but I think it can be via the pip url used in requirements.txt:

https://github.com/danieldeutsch/sacrerouge/blob/ee776dc598c952d9831e869da8bf1e5a595f7793/requirements.txt#L11

The DecomposedRouge metric setup tries to install it via download and it fails: https://github.com/danieldeutsch/sacrerouge/blob/ee776dc598c952d9831e869da8bf1e5a595f7793/sacrerouge/metrics/decomposed_rouge/decomposed_rouge.py#L243

danieldeutsch commented 3 years ago

Fixed by #72