search

danieldietrich / xtext-protected-regions

Xtext Protected Regions
danieldietrich.net
12 stars 6 forks source link

Method ProtectedRegionEclipseResourceFileSystemAccess2.file() doesn't work when the output directory in EclipseResourceFileSystemAccess2 is "." #45

Open giuseppecardenas opened 10 years ago

giuseppecardenas commented 10 years ago

When the output directory in EclipseResourceFileSystemAccess2 is set through setOutputDirectory() to be ".", the method getFolder() throws an exception. This was corrected in version 2.4 and the method getContainer() now admits the output path to be ".", but the code in this plugin still uses the getFolder() deprecated method.

danieldietrich commented 10 years ago

Thanks for reporting! You closed the issue. Should it still be fixed?

giuseppecardenas commented 10 years ago

Sorry for closing it. I had solved the problem passing "../whatever" to fsa.generateFile() to be able to generate on the project root folder, so the problem isn't so serious, but the class EclipseResourceFileSystemAccess2 should still be updated to use "getContainer()" instead of "getFolder()", so one can simply pass "." to setOutputDirectory() instead of using this workaround.

vavr-io commented 10 years ago

Thank you, I will update the project soon.