daniele77 / cli

A library for interactive command line interfaces in modern C++
Boost Software License 1.0
1.24k stars 140 forks source link

CMake dependency handling broken #117

Closed jobrud closed 3 years ago

jobrud commented 3 years ago

When the library is built for boost asio usage (with -DCLI_UseBoostAsio=ON) Boost::System is added to public link interface. That means all applications or other libraries which get linked against cli obtain automatically those dependency. Adding Boost::System to the link interface should be correct but then the cli cmake package also should take care about that dependency with:

find_dependency(Boost REQUIRED COMPONENTS system)

Which was commented out in commit fab1d7551b9c0a8a6e4d9bde6da733666f7019ef.