danieleades / monzo-lib

monzo API client library, in pure rust
16 stars 4 forks source link

Add missing transaction decline reasons #19

Closed BreD1810 closed 3 years ago

BreD1810 commented 3 years ago

Possible decline reasons include SCA_NOT_AUTHENTICATED_CARD_NOT_PRESENT and STRONG_CUSTOMER_AUTHENTICATION_REQUIRED (part of the Strong Customer Authentication scheme). Sadly, these are not documented on the Monzo documentation.

This PR:

codecov[bot] commented 3 years ago

Codecov Report

Merging #19 (1f64376) into main (8568bed) will increase coverage by 1.17%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##            main     #19      +/-   ##
========================================
+ Coverage   7.29%   8.47%   +1.17%     
========================================
  Files         18      18              
  Lines        233     236       +3     
========================================
+ Hits          17      20       +3     
  Misses       216     216              
Impacted Files Coverage Δ
src/endpoints/transactions.rs 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8568bed...1f64376. Read the comment docs.

danieleades commented 3 years ago

Thanks @BreD1810, I'll take a look this evening!

Looks like I might have to pin the clap version to get the CI passing

danieleades commented 3 years ago

@BreD1810 do you want to rebase? that should resolve the CI issue

BreD1810 commented 3 years ago

@danieleades Rebase has now fixed the CI, thanks!