danieleades commented 3 years ago

using cargo-msrv, it turns out that this crate can be compiled with a much lower MSRV, even with the updated deps. i've dropped the MSRV to reflect that.

codecov[bot] commented 3 years ago

Codecov Report

Merging #23 (ccaf94e) into main (5ccbe63) will not change coverage. The diff coverage is n/a.

:exclamation: Current head ccaf94e differs from pull request most recent head 5c943ea. Consider uploading reports for the commit 5c943ea to get more accurate results

@@          Coverage Diff          @@
##            main     #23   +/-   ##
=====================================
  Coverage   8.47%   8.47%           
=====================================
  Files         18      18           
  Lines        236     236           
=====================================
  Hits          20      20           
  Misses       216     216

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5ccbe63...5c943ea. Read the comment docs.

danieleades commented 3 years ago

msrv is fine in the end. had to use a custom 'check' command-

cargo msrv --bisect --min "1.46.0" -- cargo check --all-features --tests

danieleades / monzo-lib

bump deps and lower MSRV #23

Codecov Report