danieleades / monzo-lib

monzo API client library, in pure rust
16 stars 4 forks source link

Export accounts::Type as AccountType #25

Closed reivilibre closed 3 years ago

reivilibre commented 3 years ago

Currently accounts::Type is not exported so you can't make use of the account_type field on Account.

codecov[bot] commented 3 years ago

Codecov Report

Merging #25 (c03e184) into main (226382e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##            main     #25   +/-   ##
=====================================
  Coverage   9.04%   9.04%           
=====================================
  Files         18      18           
  Lines        221     221           
=====================================
  Hits          20      20           
  Misses       201     201           
Impacted Files Coverage Δ
src/endpoints/accounts.rs 0.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 226382e...c03e184. Read the comment docs.

danieleades commented 3 years ago

thanks for the pull request!

you're absolutely right, account::Type should be exposed and nameable.

danieleades commented 3 years ago

looks good! thanks again