danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Migrate remaining redis tests and cleanup #205

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

This PR migrates a few tests from the old unit test file to the new structure and drops the old unit test file.

It also includes some minor style fixes

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.50% // Head: 80.31% // Decreases project coverage by -0.20% :warning:

Coverage data is based on head (690764b) compared to base (d579b49). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #205 +/- ## ========================================== - Coverage 80.50% 80.31% -0.20% ========================================== Files 132 132 Lines 7991 7972 -19 ========================================== - Hits 6433 6402 -31 - Misses 1558 1570 +12 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/205?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...c/module/redis/command/module\_redis\_command\_quit.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3F1aXQuYw==) | `83.33% <100.00%> (+14.58%)` | :arrow_up: | | [...dule/redis/command/module\_redis\_command\_shutdown.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3NodXRkb3duLmM=) | `77.78% <100.00%> (+5.56%)` | :arrow_up: | | [...ule/redis/command/module\_redis\_command\_randomkey.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3JhbmRvbWtleS5j) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...tures/hashtable/mcmp/hashtable\_op\_get\_random\_key.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGUvbWNtcC9oYXNodGFibGVfb3BfZ2V0X3JhbmRvbV9rZXkuYw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [...a\_structures/hashtable/mcmp/hashtable\_op\_get\_key.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGUvbWNtcC9oYXNodGFibGVfb3BfZ2V0X2tleS5j) | `79.41% <0.00%> (-2.94%)` | :arrow_down: | | [src/module/redis/module\_redis\_command.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9tb2R1bGVfcmVkaXNfY29tbWFuZC5j) | `81.87% <0.00%> (-1.10%)` | :arrow_down: | | [src/storage/db/storage\_db.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYi5j) | `64.04% <0.00%> (-0.89%)` | :arrow_down: | | [src/network/network\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvbmV0d29ya190bHMuYw==) | `71.83% <0.00%> (-0.40%)` | :arrow_down: | | [src/utils\_string.c](https://codecov.io/gh/danielealbano/cachegrand/pull/205/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3V0aWxzX3N0cmluZy5j) | `58.70% <0.00%> (+2.90%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.