danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Fix invalid expiration time handling in set and getex #209

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

This PR fixes some minor issues in the SET and GETEX commands, the expiration time passed via EX, PX, EXAT and PXAT as always be greater then zero.

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.25% // Head: 80.31% // Increases project coverage by +0.06% :tada:

Coverage data is based on head (c9985f9) compared to base (b58e305). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #209 +/- ## ========================================== + Coverage 80.25% 80.31% +0.06% ========================================== Files 132 132 Lines 7969 7993 +24 ========================================== + Hits 6395 6419 +24 Misses 1574 1574 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/209?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [.../module/redis/command/module\_redis\_command\_getex.c](https://codecov.io/gh/danielealbano/cachegrand/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2dldGV4LmM=) | `89.13% <100.00%> (+3.84%)` | :arrow_up: | | [...rc/module/redis/command/module\_redis\_command\_set.c](https://codecov.io/gh/danielealbano/cachegrand/pull/209/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3NldC5j) | `88.89% <100.00%> (+2.22%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.