danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Implement append command #213

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

This PR implements the APPEND command and the required tests for validation

It also contains a number of fixes and improvements for the SETRANGE tests.

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.35% // Head: 80.44% // Increases project coverage by +0.09% :tada:

Coverage data is based on head (56bf74b) compared to base (00b8b28). Patch coverage: 78.21% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #213 +/- ## ========================================== + Coverage 80.35% 80.44% +0.09% ========================================== Files 135 138 +3 Lines 8062 8221 +159 ========================================== + Hits 6478 6613 +135 - Misses 1584 1608 +24 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...module/redis/command/module\_redis\_command\_append.c](https://codecov.io/gh/danielealbano/cachegrand/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2FwcGVuZC5j) | `78.21% <78.21%> (ø)` | | | [src/utils\_string.c](https://codecov.io/gh/danielealbano/cachegrand/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3V0aWxzX3N0cmluZy5j) | `58.70% <0.00%> (ø)` | | | [...module/redis/command/module\_redis\_command\_substr.c](https://codecov.io/gh/danielealbano/cachegrand/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3N1YnN0ci5j) | `93.10% <0.00%> (ø)` | | | [...c/module/redis/command/module\_redis\_command\_scan.c](https://codecov.io/gh/danielealbano/cachegrand/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3NjYW4uYw==) | `89.19% <0.00%> (ø)` | | | [src/storage/db/storage\_db.c](https://codecov.io/gh/danielealbano/cachegrand/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYi5j) | `64.69% <0.00%> (+0.64%)` | :arrow_up: | | [...c/module/redis/command/module\_redis\_command\_keys.c](https://codecov.io/gh/danielealbano/cachegrand/pull/213/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2tleXMuYw==) | `88.89% <0.00%> (+1.39%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.