danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Improve Redis module compatibility #217

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

The code changes in this PR are fairly vary, the go from a general headers cleanup to tests fixes and general redis compatibility improved.

For more detail, it's possible to review the commit history of the branch

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.56% // Head: 80.54% // Decreases project coverage by -0.02% :warning:

Coverage data is based on head (11b803d) compared to base (545b92d). Patch coverage: 77.78% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #217 +/- ## ========================================== - Coverage 80.56% 80.54% -0.02% ========================================== Files 145 145 Lines 8435 8447 +12 ========================================== + Hits 6795 6803 +8 - Misses 1640 1644 +4 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/217?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...module/redis/command/module\_redis\_command\_append.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2FwcGVuZC5j) | `78.21% <ø> (ø)` | | | [...c/module/redis/command/module\_redis\_command\_copy.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2NvcHkuYw==) | `74.42% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_dbsize.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2Ric2l6ZS5j) | `100.00% <ø> (ø)` | | | [...c/module/redis/command/module\_redis\_command\_decr.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2RlY3IuYw==) | `100.00% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_decrby.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2RlY3JieS5j) | `100.00% <ø> (ø)` | | | [...rc/module/redis/command/module\_redis\_command\_del.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2RlbC5j) | `100.00% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_exists.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2V4aXN0cy5j) | `100.00% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_expire.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2V4cGlyZS5j) | `94.44% <ø> (ø)` | | | [...dule/redis/command/module\_redis\_command\_expireat.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2V4cGlyZWF0LmM=) | `94.44% <ø> (ø)` | | | [...le/redis/command/module\_redis\_command\_expiretime.c](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2V4cGlyZXRpbWUuYw==) | `92.86% <ø> (ø)` | | | ... and [35 more](https://codecov.io/gh/danielealbano/cachegrand/pull/217/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.