danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Fix hashtable counter expansion #228

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

Fix a bug introduced with the hashtable counters that was triggered when using more than one thread, it's necessary to not only introduce tests for the hashtable counters but also change the amount of workers used in the tests to ensure that the multi-threading aspect is tested properly

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.89% // Head: 80.89% // No change to project coverage :thumbsup:

Coverage data is based on head (49a67f6) compared to base (c830e61). Patch coverage: 66.67% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #228 +/- ## ======================================= Coverage 80.89% 80.89% ======================================= Files 152 152 Lines 8706 8706 ======================================= Hits 7042 7042 Misses 1664 1664 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/228?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...uctures/hashtable/mcmp/hashtable\_thread\_counters.c](https://codecov.io/gh/danielealbano/cachegrand/pull/228/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGUvbWNtcC9oYXNodGFibGVfdGhyZWFkX2NvdW50ZXJzLmM=) | `75.81% <66.67%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.