danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Increase the max number of recv by 5 to fix flakyness #229

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

This PR fixes a test for the Redis SET command which is flaky and in some cases the server needs to send an extra packet.

For a normal client this isn't a problem per-se, as it parses the protocol, but the unit tests use a dummy system to keep it as simple as possible and need to know how many packets might be send maximum.

To resolve the flakyness the test has been updated to expect potentially 5 extra packets.

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.89% // Head: 80.89% // No change to project coverage :thumbsup:

Coverage data is based on head (a81d643) compared to base (c830e61). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #229 +/- ## ======================================= Coverage 80.89% 80.89% ======================================= Files 152 152 Lines 8706 8706 ======================================= Hits 7042 7042 Misses 1664 1664 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/229?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...uctures/hashtable/mcmp/hashtable\_thread\_counters.c](https://codecov.io/gh/danielealbano/cachegrand/pull/229/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGUvbWNtcC9oYXNodGFibGVfdGhyZWFkX2NvdW50ZXJzLmM=) | `75.81% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.