danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Implement types support in the storage db #232

Closed danielealbano closed 2 years ago

danielealbano commented 2 years ago

This PR adds the necessary field to the storage db entry index to indicate which type of data are stored in the value chunk sequence.

The 2 interfaces that create and write entry indexes have been updated as well to allow specifying the type and the Redis commands have been updated to take advantage of the new interface.

This PR closes #221

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.87% // Head: 80.85% // Decreases project coverage by -0.01% :warning:

Coverage data is based on head (2c053be) compared to base (0edcfa0). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #232 +/- ## ========================================== - Coverage 80.87% 80.85% -0.01% ========================================== Files 152 152 Lines 8707 8707 ========================================== - Hits 7041 7040 -1 - Misses 1666 1667 +1 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/232?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...nd/helpers/module\_redis\_command\_helper\_incr\_decr.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL2hlbHBlcnMvbW9kdWxlX3JlZGlzX2NvbW1hbmRfaGVscGVyX2luY3JfZGVjci5j) | `85.90% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_append.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2FwcGVuZC5j) | `78.82% <ø> (ø)` | | | [...c/module/redis/command/module\_redis\_command\_copy.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2NvcHkuYw==) | `77.08% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_getset.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2dldHNldC5j) | `78.57% <ø> (ø)` | | | [...c/module/redis/command/module\_redis\_command\_mset.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX21zZXQuYw==) | `88.89% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_msetnx.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX21zZXRueC5j) | `85.71% <ø> (ø)` | | | [...module/redis/command/module\_redis\_command\_psetex.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3BzZXRleC5j) | `89.47% <ø> (ø)` | | | [...rc/module/redis/command/module\_redis\_command\_set.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3NldC5j) | `88.61% <ø> (ø)` | | | [.../module/redis/command/module\_redis\_command\_setex.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3NldGV4LmM=) | `89.47% <ø> (ø)` | | | [.../module/redis/command/module\_redis\_command\_setnx.c](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX3NldG54LmM=) | `80.56% <ø> (ø)` | | | ... and [3 more](https://codecov.io/gh/danielealbano/cachegrand/pull/232/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.