danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

docs(benches): `storage` fixup #237

Closed ryanrussell closed 2 years ago

ryanrussell commented 2 years ago

Signed-off-by: Ryan Russell git@ryanrussell.org

Small fixup in the benchmarks comment.

grep -r stoarge
bench-hashtable-mpmc-op-set.cpp:            // Free the stoarge
bench-hashtable-mpmc-op-set.cpp:            // Free the stoarge
bench-storage-db-op-set.cpp:            // Free the stoarge

Checked to ensure there are no further matches in the repo outside this directory

codecov[bot] commented 2 years ago

Codecov Report

Base: 80.85% // Head: 80.87% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (82bcf9e) compared to base (2d3398e). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #237 +/- ## ========================================== + Coverage 80.85% 80.87% +0.01% ========================================== Files 152 152 Lines 8707 8707 ========================================== + Hits 7040 7041 +1 + Misses 1667 1666 -1 ``` | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/237?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/xalloc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/237/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3hhbGxvYy5j) | `97.10% <0.00%> (+1.45%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

danielealbano commented 2 years ago

I need to fix the flaky test for the 256mb set, it randomly misses the ending new line terminator 🙃