danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Fix the "missing .note.GNU-stack section implies executable stack" warning #275

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR adds the .note.GNU-stack section to the fiber-context assembly files for both AARCH64 (ARM64) and X86-64 (X64).

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.97% // Head: 82.94% // Decreases project coverage by -0.03% :warning:

Coverage data is based on head (535c6a2) compared to base (86ba42a). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #275 +/- ## ========================================== - Coverage 82.97% 82.94% -0.03% ========================================== Files 158 158 Lines 10262 10262 ========================================== - Hits 8514 8511 -3 - Misses 1748 1751 +3 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `82.94% <ø> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/xalloc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3hhbGxvYy5j) | `95.71% <0.00%> (-1.43%)` | :arrow_down: | | [...rc/data\_structures/hashtable\_mpmc/hashtable\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGVfbXBtYy9oYXNodGFibGVfbXBtYy5j) | `96.11% <0.00%> (-0.69%)` | :arrow_down: | | [src/transaction\_spinlock.h](https://codecov.io/gh/danielealbano/cachegrand/pull/275?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3RyYW5zYWN0aW9uX3NwaW5sb2NrLmg=) | `95.00% <0.00%> (+5.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.