codecov[bot]
commented
1 year ago Codecov Report
Base: 82.91% // Head: 82.98% // Increases project coverage by +0.08% :tada:
Coverage data is based on head (
3c53e17) compared to base (feb201f). Patch has no changes to coverable lines.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #276 +/- ## ========================================== + Coverage 82.91% 82.98% +0.08% ========================================== Files 158 158 Lines 10262 10243 -19 ========================================== - Hits 8508 8500 -8 + Misses 1754 1743 -11 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `82.98% <ø> (+0.08%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/network/io/network\_io\_common\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvaW8vbmV0d29ya19pb19jb21tb25fdGxzLmM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [src/transaction\_spinlock.h](https://codecov.io/gh/danielealbano/cachegrand/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3RyYW5zYWN0aW9uX3NwaW5sb2NrLmg=) | `90.00% <0.00%> (-5.00%)` | :arrow_down: | | [src/network/network\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvbmV0d29ya190bHMuYw==) | `71.83% <0.00%> (-0.40%)` | :arrow_down: | | [...rc/data\_structures/hashtable\_mpmc/hashtable\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGVfbXBtYy9oYXNodGFibGVfbXBtYy5j) | `95.42% <0.00%> (ø)` | | | [src/network/channel/network\_channel\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/276?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvY2hhbm5lbC9uZXR3b3JrX2NoYW5uZWxfdGxzLmM=) | `1.36% <0.00%> (+0.16%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Ninja works slightly differently than name and it needs to be aware of all the targets being used, doesn't just rely on the high level dependency tree defined via cmake itself.
This PR adds the BUILD_BYPRODUCTS to make cmake aware of the targets generated by the external components built via ExternalProject_Add so that ninja can follow up the dependency tree as needed.