danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

The interface has been refactored to ensure that hashtable_mpmc_op_set returns a successful result only if the value is updated therefore is not necessary anymore passing out the result as flag #277

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

The interface has been refactored to ensure that hashtable_mpmc_op_set returns a successful result only if the value is updated therefore is not necessary anymore passing out the result as flag.

This PR fixes the hashtable mpmc new op set benchmark dropping the usage of the flag in the code (declarations, asserts and the value passed to the function).

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.77% // Head: 82.97% // Increases project coverage by +0.20% :tada:

Coverage data is based on head (ca1f8f4) compared to base (0ea6e18). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #277 +/- ## ========================================== + Coverage 82.77% 82.97% +0.20% ========================================== Files 158 158 Lines 10261 10242 -19 ========================================== + Hits 8493 8498 +5 + Misses 1768 1744 -24 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `82.97% <ø> (+0.20%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/network/io/network\_io\_common\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvaW8vbmV0d29ya19pb19jb21tb25fdGxzLmM=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [src/network/network\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvbmV0d29ya190bHMuYw==) | `71.83% <0.00%> (ø)` | | | [src/network/channel/network\_channel\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvY2hhbm5lbC9uZXR3b3JrX2NoYW5uZWxfdGxzLmM=) | `1.36% <0.00%> (+0.16%)` | :arrow_up: | | [...rc/data\_structures/hashtable\_mpmc/hashtable\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGVfbXBtYy9oYXNodGFibGVfbXBtYy5j) | `94.95% <0.00%> (+2.29%)` | :arrow_up: | | [src/transaction\_spinlock.h](https://codecov.io/gh/danielealbano/cachegrand/pull/277?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3RyYW5zYWN0aW9uX3NwaW5sb2NrLmg=) | `95.00% <0.00%> (+5.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.