danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Drop hashtable mpmc block size re-calculation when upsizing #278

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR drops a recalculation of the size of the blocks to migrate when up-sizing, there is no reason or practical advantage in having it, the value should always be set to what has been requested when the hashtable is initialized.

As part of the PR tests are updated as well as necessary.

codecov[bot] commented 1 year ago

Codecov Report

Base: 82.97% // Head: 82.76% // Decreases project coverage by -0.21% :warning:

Coverage data is based on head (13163f2) compared to base (805e65b). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #278 +/- ## ========================================== - Coverage 82.97% 82.76% -0.21% ========================================== Files 158 158 Lines 10262 10261 -1 ========================================== - Hits 8514 8492 -22 - Misses 1748 1769 +21 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `82.76% <100.00%> (-0.21%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...rc/data\_structures/hashtable\_mpmc/hashtable\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGVfbXBtYy9oYXNodGFibGVfbXBtYy5j) | `93.81% <100.00%> (-3.22%)` | :arrow_down: | | [src/epoch\_gc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2Vwb2NoX2djLmM=) | `95.63% <0.00%> (-3.40%)` | :arrow_down: | | [src/network/network\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvbmV0d29ya190bHMuYw==) | `71.83% <0.00%> (-0.40%)` | :arrow_down: | | [src/xalloc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/278?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3hhbGxvYy5j) | `97.14% <0.00%> (+1.43%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.