danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Improve config file validation #287

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR improves the config file validation that runs when the config fle is initially loaded.

The validation has been re-organized into specific sections matching the structure of the config file and some minor glitches have been ironed out:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 73.23% and project coverage change: -0.09 :warning:

Comparison is base (36fcca8) 83.06% compared to head (191246b) 82.97%.

:exclamation: Current head 191246b differs from pull request most recent head f0f286a. Consider uploading reports for the commit f0f286a to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #287 +/- ## ========================================== - Coverage 83.06% 82.97% -0.09% ========================================== Files 161 161 Lines 10524 10622 +98 ========================================== + Hits 8741 8813 +72 - Misses 1783 1809 +26 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `82.97% <73.23%> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/config\_cyaml\_schema.c](https://codecov.io/gh/danielealbano/cachegrand/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZ19jeWFtbF9zY2hlbWEuYw==) | `100.00% <ø> (ø)` | | | [src/config.c](https://codecov.io/gh/danielealbano/cachegrand/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZy5j) | `87.54% <73.23%> (-10.95%)` | :arrow_down: | | [...rc/data\_structures/hashtable\_mpmc/hashtable\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9oYXNodGFibGVfbXBtYy9oYXNodGFibGVfbXBtYy5j) | `93.69% <0.00%> (+1.38%)` | :arrow_up: | | [src/transaction\_spinlock.h](https://codecov.io/gh/danielealbano/cachegrand/pull/287?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3RyYW5zYWN0aW9uX3NwaW5sb2NrLmg=) | `95.00% <0.00%> (+5.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.