danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Bug free pages in queue mpmc #299

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

The previous merge was containing some cleaup code commented out. This PR restores it and cleans up some security bug reported by codeql.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.12 :tada:

Comparison is base (5b405f3) 81.73% compared to head (5a4bccf) 81.85%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #299 +/- ## ========================================== + Coverage 81.73% 81.85% +0.12% ========================================== Files 164 164 Lines 11057 11041 -16 ========================================== Hits 9037 9037 + Misses 2020 2004 -16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `81.85% <100.00%> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/data\_structures/queue\_mpmc/queue\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/299?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9xdWV1ZV9tcG1jL3F1ZXVlX21wbWMuYw==) | `100.00% <100.00%> (+2.53%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/299/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.