danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Ensure all the log data are always written to disk #321

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR changes the behaviour of log_sink_file_printer to ensure that all the log data are always written to the disk.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.06 :warning:

Comparison is base (5f046df) 78.60% compared to head (7d0c4b7) 78.54%.

:exclamation: Current head 7d0c4b7 differs from pull request most recent head 854d725. Consider uploading reports for the commit 854d725 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #321 +/- ## ========================================== - Coverage 78.60% 78.54% -0.06% ========================================== Files 173 173 Lines 12103 12109 +6 ========================================== - Hits 9513 9510 -3 - Misses 2590 2599 +9 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.54% <0.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/log/sink/log\_sink\_file.c](https://codecov.io/gh/danielealbano/cachegrand/pull/321?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2xvZy9zaW5rL2xvZ19zaW5rX2ZpbGUuYw==) | `36.67% <0.00%> (-9.17%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/321/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.