danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

In slots bitmap mpmc allocate the memory via mmap instead of ffma #341

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

To allow allocations larger than 64k use mmap directly instead of ffma, there are no small bitmaps allocated internally so in general there will be no memory wasted or will be a very small percentage (1 page - 1 byte).

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.05 :warning:

Comparison is base (3f124ab) 77.13% compared to head (4270090) 77.08%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #341 +/- ## ========================================== - Coverage 77.13% 77.08% -0.05% ========================================== Files 179 179 Lines 12415 12416 +1 ========================================== - Hits 9576 9570 -6 - Misses 2839 2846 +7 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `77.08% <100.00%> (-0.05%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...a\_structures/slots\_bitmap\_mpmc/slots\_bitmap\_mpmc.h](https://codecov.io/gh/danielealbano/cachegrand/pull/341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9zbG90c19iaXRtYXBfbXBtYy9zbG90c19iaXRtYXBfbXBtYy5o) | `97.30% <ø> (ø)` | | | [...a\_structures/slots\_bitmap\_mpmc/slots\_bitmap\_mpmc.c](https://codecov.io/gh/danielealbano/cachegrand/pull/341?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2RhdGFfc3RydWN0dXJlcy9zbG90c19iaXRtYXBfbXBtYy9zbG90c19iaXRtYXBfbXBtYy5j) | `95.18% <100.00%> (+0.06%)` | :arrow_up: | ... and [3 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/341/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.