danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Don't report an error if the io_uring fd registration fails #364

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR changes the severity of the message reported in case the (pre-)registration of the file descriptor used by io_uring fails.

This functionality requires a recent kernel but as there is no real downside if it fails, apart from not having the functionality enabled in io_uring, it's not really worth to report the failure as a warning. Therefore this PR reduces the severity of the message down to a mere verbose message in case it fails.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 :tada:

Comparison is base (b872b52) 79.08% compared to head (60c0074) 79.09%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #364 +/- ## ========================================== + Coverage 79.08% 79.09% +0.02% ========================================== Files 182 182 Lines 12609 12609 ========================================== + Hits 9971 9973 +2 + Misses 2638 2636 -2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `79.09% <100.00%> (+0.02%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/support/io\_uring/io\_uring\_support.c](https://codecov.io/gh/danielealbano/cachegrand/pull/364?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N1cHBvcnQvaW9fdXJpbmcvaW9fdXJpbmdfc3VwcG9ydC5j) | `82.42% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/364/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.