danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

When validating the configuration, ensure that the keepalive is valid #372

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR add validation for the keepalive settings, if present but set to zero are currently accepted and this will cause a number of errors printed out on the console on every new connection.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 60.00% and project coverage change: -0.06 :warning:

Comparison is base (90b8ca9) 78.70% compared to head (db5b11e) 78.64%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #372 +/- ## ========================================== - Coverage 78.70% 78.64% -0.06% ========================================== Files 184 184 Lines 12871 12867 -4 ========================================== - Hits 10130 10119 -11 - Misses 2741 2748 +7 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.64% <60.00%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/config.c](https://codecov.io/gh/danielealbano/cachegrand/pull/372?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZy5j) | `79.25% <60.00%> (-0.53%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/372/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.