danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Fix ca load #373

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR changes on the CA certificate is loaded, instead of expecting it to be the second in the server certificate it adds a new field to the configuration file called ca_certificate_chain_path which can be used to load a chain of ca certificates.

This change is also required for another functionality which will be introduced afterward to enable or disable the client certificate verification.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 22.22% and project coverage change: -0.11 :warning:

Comparison is base (8f52bd6) 78.65% compared to head (54d3c86) 78.55%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #373 +/- ## ========================================== - Coverage 78.65% 78.55% -0.11% ========================================== Files 184 184 Lines 12886 12874 -12 ========================================== - Hits 10135 10112 -23 - Misses 2751 2762 +11 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.55% <22.22%> (-0.11%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/config\_cyaml\_schema.c](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZ19jeWFtbF9zY2hlbWEuYw==) | `100.00% <ø> (ø)` | | | [src/network/network\_tls.h](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvbmV0d29ya190bHMuaA==) | `100.00% <ø> (ø)` | | | [src/worker/network/worker\_network\_iouring\_op.c](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3dvcmtlci9uZXR3b3JrL3dvcmtlcl9uZXR3b3JrX2lvdXJpbmdfb3AuYw==) | `65.36% <ø> (ø)` | | | [src/worker/network/worker\_network\_op.c](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3dvcmtlci9uZXR3b3JrL3dvcmtlcl9uZXR3b3JrX29wLmM=) | `71.07% <0.00%> (-0.45%)` | :arrow_down: | | [src/worker/worker.c](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3dvcmtlci93b3JrZXIuYw==) | `83.49% <ø> (ø)` | | | [src/config.c](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZy5j) | `78.86% <25.00%> (-0.39%)` | :arrow_down: | | [src/network/network\_tls.c](https://codecov.io/gh/danielealbano/cachegrand/pull/373?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL25ldHdvcmsvbmV0d29ya190bHMuYw==) | `70.87% <25.00%> (-1.36%)` | :arrow_down: | ... and [5 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/373/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.