danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Expose the general config to the module validation, not only the one … #384

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR changes the modules callback to validate the config file once it has been loaded to expose not only the module config but also the general config.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 70.00% and project coverage change: -0.12 :warning:

Comparison is base (5856785) 78.38% compared to head (21e02d7) 78.25%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #384 +/- ## ========================================== - Coverage 78.38% 78.25% -0.12% ========================================== Files 187 187 Lines 13014 13014 ========================================== - Hits 10200 10184 -16 - Misses 2814 2830 +16 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.25% <70.00%> (-0.12%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/danielealbano/cachegrand/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/module/module.h](https://codecov.io/gh/danielealbano/cachegrand/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9tb2R1bGUuaA==) | `66.67% <ø> (ø)` | | | [src/config.c](https://codecov.io/gh/danielealbano/cachegrand/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZy5j) | `77.99% <66.67%> (ø)` | | | [src/module/redis/module\_redis\_config.c](https://codecov.io/gh/danielealbano/cachegrand/pull/384?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9tb2R1bGVfcmVkaXNfY29uZmlnLmM=) | `100.00% <100.00%> (ø)` | | ... and [2 files with indirect coverage changes](https://codecov.io/gh/danielealbano/cachegrand/pull/384/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.