danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Feat storage buffered channels #390

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR implements the buffered reads and write support basic infrastructure and update the rdb save component to leverage it

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 67.98% and project coverage change: +0.07 :tada:

Comparison is base (32894b4) 78.10% compared to head (ced419a) 78.18%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #390 +/- ## ========================================== + Coverage 78.10% 78.18% +0.07% ========================================== Files 187 190 +3 Lines 12989 13100 +111 ========================================== + Hits 10145 10241 +96 - Misses 2844 2859 +15 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.18% <67.98%> (+0.07%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/clock.h](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2Nsb2NrLmg=) | `95.12% <ø> (ø)` | | | [...module/redis/snapshot/module\_redis\_snapshot\_load.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9zbmFwc2hvdC9tb2R1bGVfcmVkaXNfc25hcHNob3RfbG9hZC5j) | `33.19% <ø> (-0.29%)` | :arrow_down: | | [src/storage/db/storage\_db.h](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYi5o) | `27.27% <ø> (ø)` | | | [src/storage/db/storage\_db\_snapshot.h](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYl9zbmFwc2hvdC5o) | `25.81% <ø> (ø)` | | | [src/storage/db/storage\_db\_snapshot.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYl9zbmFwc2hvdC5j) | `42.31% <31.58%> (-1.20%)` | :arrow_down: | | [src/storage/storage\_buffered.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2Uvc3RvcmFnZV9idWZmZXJlZC5j) | `92.86% <92.86%> (ø)` | | | [src/storage/storage\_buffered.h](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2Uvc3RvcmFnZV9idWZmZXJlZC5o) | `92.86% <92.86%> (ø)` | | | [src/clock.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2Nsb2NrLmM=) | `100.00% <100.00%> (ø)` | | | [src/log/log.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2xvZy9sb2cuYw==) | `100.00% <100.00%> (ø)` | | | [src/storage/channel/storage\_buffered\_channel.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvY2hhbm5lbC9zdG9yYWdlX2J1ZmZlcmVkX2NoYW5uZWwuYw==) | `100.00% <100.00%> (ø)` | | | ... and [2 more](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | | ... and [4 files with indirect coverage changes](https://app.codecov.io/gh/danielealbano/cachegrand/pull/390/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.