danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Refactor AUTH and HELLO implementation to abstract away all the business logic #397

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR reorganise the AUTH and HELLO command to abstract away into helpers all the business logic.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 83.64% and project coverage change: -0.01 :warning:

Comparison is base (d9c82ae) 78.27% compared to head (149627b) 78.26%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #397 +/- ## ========================================== - Coverage 78.27% 78.26% -0.01% ========================================== Files 192 193 +1 Lines 13203 13231 +28 ========================================== + Hits 10334 10354 +20 - Misses 2869 2877 +8 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `78.26% <83.64%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/danielealbano/cachegrand/pull/397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...c/module/redis/command/module\_redis\_command\_auth.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2F1dGguYw==) | `100.00% <ø> (ø)` | | | [...ommand/helpers/module\_redis\_command\_helper\_hello.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL2hlbHBlcnMvbW9kdWxlX3JlZGlzX2NvbW1hbmRfaGVscGVyX2hlbGxvLmM=) | `80.22% <80.22%> (ø)` | | | [...command/helpers/module\_redis\_command\_helper\_auth.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL2hlbHBlcnMvbW9kdWxlX3JlZGlzX2NvbW1hbmRfaGVscGVyX2F1dGguYw==) | `88.89% <100.00%> (+1.79%)` | :arrow_up: | | [.../module/redis/command/module\_redis\_command\_hello.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/397?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9jb21tYW5kL21vZHVsZV9yZWRpc19jb21tYW5kX2hlbGxvLmM=) | `100.00% <100.00%> (+21.95%)` | :arrow_up: | ... and [2 files with indirect coverage changes](https://app.codecov.io/gh/danielealbano/cachegrand/pull/397/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.