danielealbano / cachegrand

cachegrand - a modern data ingestion, processing and serving platform built for today's hardware
BSD 3-Clause "New" or "Revised" License
975 stars 34 forks source link

Impl commands disable #417

Closed danielealbano closed 1 year ago

danielealbano commented 1 year ago

This PR introduces a new mechanism to disable commands via the config file, a new parameter called disabled_commands has been introduced.

The PR changes the following things:

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage: 65.71% and project coverage change: +0.03 :tada:

Comparison is base (5ef5bf7) 76.85% compared to head (7d34c2b) 76.88%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #417 +/- ## ========================================== + Coverage 76.85% 76.88% +0.03% ========================================== Files 198 199 +1 Lines 13586 13621 +35 ========================================== + Hits 10441 10472 +31 - Misses 3145 3149 +4 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `76.88% <65.71%> (+0.03%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [src/config\_cyaml\_schema.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL2NvbmZpZ19jeWFtbF9zY2hlbWEuYw==) | `100.00% <ø> (ø)` | | | [src/module/redis/module\_redis.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9tb2R1bGVfcmVkaXMuYw==) | `66.67% <55.56%> (-16.67%)` | :arrow_down: | | [src/module/redis/module\_redis\_commands.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9tb2R1bGVfcmVkaXNfY29tbWFuZHMuYw==) | `85.25% <63.64%> (-4.75%)` | :arrow_down: | | [src/module/redis/module\_redis\_commands.h](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9tb2R1bGVfcmVkaXNfY29tbWFuZHMuaA==) | `100.00% <100.00%> (ø)` | | | [src/module/redis/module\_redis\_connection.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9tb2R1bGVfcmVkaXNfY29ubmVjdGlvbi5j) | `74.70% <100.00%> (+0.19%)` | :arrow_up: | ... and [5 files with indirect coverage changes](https://app.codecov.io/gh/danielealbano/cachegrand/pull/417/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.