codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 9.09% and no project coverage change.
Comparison is base (
bec26a4) 76.76% compared to head (550cfb2) 76.75%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## main #422 +/- ## ========================================== - Coverage 76.76% 76.75% -0.00% ========================================== Files 199 199 Lines 13629 13635 +6 ========================================== + Hits 10461 10465 +4 - Misses 3168 3170 +2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `76.75% <9.09%> (-<0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://app.codecov.io/gh/danielealbano/cachegrand/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano) | Coverage Δ | | |---|---|---| | [...fiber/module\_redis\_fiber\_storage\_db\_snapshot\_rdb.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL21vZHVsZS9yZWRpcy9maWJlci9tb2R1bGVfcmVkaXNfZmliZXJfc3RvcmFnZV9kYl9zbmFwc2hvdF9yZGIuYw==) | `72.22% <0.00%> (ø)` | | | [src/storage/db/storage\_db\_snapshot.h](https://app.codecov.io/gh/danielealbano/cachegrand/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYl9zbmFwc2hvdC5o) | `25.81% <ø> (ø)` | | | [src/storage/db/storage\_db\_snapshot.c](https://app.codecov.io/gh/danielealbano/cachegrand/pull/422?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano#diff-c3JjL3N0b3JhZ2UvZGIvc3RvcmFnZV9kYl9zbmFwc2hvdC5j) | `42.62% <10.00%> (-0.37%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/danielealbano/cachegrand/pull/422/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniele+Salvatore+Albano):umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
This PR fixes a bug in the design of how failures are handled by the snapshotting process introducing a flag to identify if a failure happened during the preparation phase or during the processing.
It's not a perfect solution, as currently it's woking because there are only 2 kind of failures, but any additional failure status would require anyway some major changes therefore for now it's good enough.