search

danielebogo / DBCamera

DBCamera is a simple custom camera with AVFoundation
MIT License
1.26k stars 261 forks source link

Add more image editing features #28

Open rgallagher27 opened 10 years ago

rgallagher27 commented 10 years ago

Just wondering if there are any plans to implement more image editing features than just a basic crop?

If there are and you are open to pull requests I've been working on a forked version of this repo that replaces the DBCameraSegueViewController with this project: CLImageEditor as it provides a lot of great image editing tools without changing the basic flow of this project.

rgallagher27 commented 10 years ago

There are a few changes to CLImageEditor I have made waiting to be merged into the master branch that would allow a black theme to tie in with this project

danielebogo commented 10 years ago

Hi @rgallagher27 , yes i would implement some features in the future. Firstly the filters, using GPUImage (using the curves exported from Photoshop). In the new version of DBCamera, i've modified the crop property with the bounds check and rotation with the gesture. I would to avoid using others external libraries. CLImageEditor has many good functionalities. I don't like the UI, but could be a solution. But i would to try to recreate the functionalities before implementing another library. Anyway, i'm always open to pull requests, with bug fix or new features. Is not a problem. Let me know what you think about the future features ok?

rgallagher27 commented 10 years ago

No problem, I just needed a full feature solution that didn't have to present a new view to edit the image form DBCamera now.

I'll hopefully be able to contribute some image editor features to this project with the hope that I can replace my fork (with the CLImageEditor addition) with just this project.

Some of the basic future features I would like to see are Image Filters, Image Adjustments (i.e white balance), Image Blur and The ability to add Text?

danielebogo commented 10 years ago

A new version in Swift is an idea for a future version available only for iOS 8 and 7, using only the iOS API without GPUImage or other libraries, but i would to complete other tasks before.

--  Daniele Bogo

On 2 Oct 2014 at 15:48:25, Christian Paul (notifications@github.com) wrote:

Just wanted to say some additional formatting would be great (especially text overlay)! Are you still rewriting this in Swift? And if so would it be best to add that functionality to the Swift version?

— Reply to this email directly or view it on GitHub.