danielenricocahall / elephas

Distributed Deep learning with Keras & Spark
MIT License
17 stars 5 forks source link

Cannot install elephas 3.4.2 #17

Closed blankdots closed 1 year ago

blankdots commented 1 year ago

Describe the bug Cannot install elephas, seems to happen with the latest version 3.4.2

The error is, when i try to upgrade (it is similar when I try a fresh install):

Requirement already satisfied: elephas in /usr/local/lib/python3.9/site-packages (3.1.0)
Collecting elephas
  Downloading elephas-3.4.2.tar.gz (28 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
× python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-8kxk_o1d/elephas_a86f277830374d25acc15784076e2a61/setup.py", line 11, in <module>
          install_requires=[line.strip() for line in open('requirements.txt').readlines()],
      FileNotFoundError: [Errno 2] No such file or directory: 'requirements.txt'
      [end of output]

To Reproduce Steps to reproduce the behavior.

pip install --upgrade elephas
#or
pip install elephas

Expected behavior A clear and concise description of what you expected to happen. Able to install elephas

Desktop (please complete the following information):

Python version: 3.9 pip version: 22.1.1

Additional context Add any other context about the problem here.

danielenricocahall commented 1 year ago

Hello @blankdots , thank you for raising this to my attention! Yes, I see what the issue is - looks like in a previous PR, setup.py was changed to use the requirements.txt file as the install_requires argument, but we don't package the requirements.txt file, hence the error. I've addressed it in the newest release (3.4.3) by reverting that change and manually specifying deps - please try installing now and let me know!

blankdots commented 1 year ago

Hello @blankdots , thank you for raising this to my attention! Yes, I see what the issue is - looks like in a previous PR, setup.py was changed to use the requirements.txt file as the install_requires argument, but we don't package the requirements.txt file, hence the error. I've addressed it in the newest release (3.4.3) by reverting that change and manually specifying deps - please try installing now and let me know!

There might be a small typo: https://github.com/danielenricocahall/elephas/blob/master/setup.py#L11 is iinstall_requires (extra i)

danielenricocahall commented 1 year ago

Good catch, thank you! That has been corrected, and along with some other changes for copying the documentation over to PyPI, has been bundled into 3.4.7. Please try again at earliest convenience!

blankdots commented 1 year ago

seems to work, closing as completed