search

danieleongari / CURATED-COFs

Clean, Uniform and Refined with Automatic Tracking from Experimental Database (CURATED) COFs
MIT License
34 stars 11 forks source link

Add formatter & validation #9

Closed ltalirz closed 4 years ago

ltalirz commented 4 years ago

This PR adds

See here for the result of the check.

ltalirz commented 4 years ago

@danieleongari We can also decide to remove the "trailing whitespace" fixer, which is the only one making changes here I believe. Is there a particular reason why manage-crystal adds whitespace at the end of some lines?

danieleongari commented 4 years ago

I fixed the DOI in dcf1ee90349ba9b33803faf97463e179fd312fd1 and I will fix manage crystal to remove these spaces. I remember I was using a space instead of just an empty line because of a program that was failing the parsing otherwise. But it is an old story and no need for legacy.

When loaded as CifData, these CIFs will have a different hashkey but I don't think it is a problem, and would be to subtle to maintain anyway!

Please merge!

ltalirz commented 4 years ago

When loaded as CifData, these CIFs will have a different hashkey

Hm... this is a good point, and currently we don't have a strong reason to change the files. I have commented out the "trailing whitespace fixer" for the moment; we can always add it back when we need to.

Fixing manage crystal not to include them still makes sense.