search

danielepiccone / ng-pageslide

AngularJS sliding panel for serving additional content from off the page
http://danielepiccone.github.io/ng-pageslide/examples/
452 stars 162 forks source link

destroy method removing child #141

Closed technimadhu closed 7 years ago

technimadhu commented 7 years ago

Request SME's opinion on how to handle this.

  1. I have multiple tabs (each has its own scope) and tab change causes new route( using ui-router). the page slide is used in each tab. When i switch tabs, the destroy event on pageSlide removes the 'childElements' which contains my button (which is inside the page-slide directive). The problem is i have no control on when this destroy is called. Sometimes its called after the new tab is created with the button and then the old scope's destroy fires removing the button . If i comment out the removeChild in destroy, then it helps my situation. could this be provided as an option? i.e. dont destroy if option is passed?
technimadhu commented 7 years ago

closing this - bug in my state change - notify: false not set properly.