danieleteti / loggerpro

An modern and pluggable logging framework for Delphi
Apache License 2.0
352 stars 91 forks source link

Feature Request for low level Windows Event logger #63

Closed HealthOneNZ closed 1 year ago

HealthOneNZ commented 1 year ago

The current implementation requires a TService instance to be passed to the constructor of TLoggerProWindowsEventLogAppender

This limits the use of the logger to service applications.

I've written a unit which allows the service name (or a proxy of that) to be passed as plain text and a separate instance of the low level windows event logger is created.

Happy to share this code with the project. Usage is is simple as

var SIEMLog: ILogWriter; ... SIEMLog := BuildLogWriter([TLoggerProWindowsEventLogAppenderLL.Create('TheServiceName")]); ... SIEMLog.Debug('This is a test message');

``

danieleteti commented 1 year ago

Would be great. Feel free to provide a PR with your new Appender

HealthOneNZ commented 1 year ago

I'll take a look at it when I get back from leave in mid Jan (summer where I live)

In the meantime we're getting a recurrence of the bug where the LoggerPro runs out of queue, not sure if this is due to higher throughput or the fact we have a second log queue which is writing to the Windows Event log which is slower to dequeue.

Anyway that is a problem for 2023.

In the meantime, many thanks for your leadership with this great library.

Cheers

David

David Moorhouse (BCom) | Development Manager Regional HealthOne Programme P: 03 353 0871 E: @.**@.> 401 Madras St, Christchurch 8013 PO Box 741, Christchurch 8140 @.***

From: Daniele Teti @.> Sent: Thursday, 15 December 2022 1:57 am To: danieleteti/loggerpro @.> Cc: David Moorhouse @.>; Author @.> Subject: Re: [danieleteti/loggerpro] Feature Request for low level Windows Event logger (Issue #63)

Would be great. Feel free to provide a PR with your new Appender

- Reply to this email directly, view it on GitHubhttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fdanieleteti%2Floggerpro%2Fissues%2F63%23issuecomment-1351303076&data=05%7C01%7Cdavid_m%40pegasushealth.mail.onmicrosoft.com%7Cffeebd5673ae4d75b23108daddd2b6a9%7C3ee1ab78075342db8dab9bf1b07b2b1a%7C0%7C0%7C638066194337989926%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=IgpQ6a%2F%2FYZnr%2BrcJRHT%2BwxMLVUpcnXcwWFSb3gz17%2Fc%3D&reserved=0, or unsubscribehttps://aus01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAWEGRWHPLQ37N5LOREQOVK3WNG72DANCNFSM6AAAAAASBVMZWU&data=05%7C01%7Cdavid_m%40pegasushealth.mail.onmicrosoft.com%7Cffeebd5673ae4d75b23108daddd2b6a9%7C3ee1ab78075342db8dab9bf1b07b2b1a%7C0%7C0%7C638066194337989926%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gh3DuAOfvCUrTBEIHydKQkpBhStjoxEucTYC2d0KadY%3D&reserved=0. You are receiving this because you authored the thread.Message ID: @.**@.>>


This email or attachment(s) may contain confidential or legally privileged information intended for the sole use of the addressee(s). Any use, redistribution, disclosure, or reproduction of this message, except as intended, is prohibited. If you received this email in error, please notify the sender and erase all copies of the message, including any attachments. Any views or opinions expressed in this email (unless otherwise stated) may not represent those of Pegasus Health Ltd.


danieleteti commented 1 year ago

Any news?

fastbike commented 1 year ago

We're using the innards of the TService windows event logger, but are having some stability issues which we are working through.