search

danielfalk / smart-open.nvim

Neovim plugin for fast file-finding
MIT License
498 stars 25 forks source link

feat: ability to customize buffer indicators #51

Closed dlvhdr closed 10 months ago

dlvhdr commented 10 months ago
image
dlvhdr commented 10 months ago

Hey @danielfalk is this something you'd like merged?

danielfalk commented 10 months ago

Yes, the code looks good. Thanks. Just as a side note, I want to be more careful than I have before when it comes to adding configuration. I know this goes against the community's desire to customize every last thing. But for me, I'd rather provide defaults that work really well when possible. Partially that's because there are more possible combinations of setups to test, and also because then the plugin is more complicated to setup and use than necessary. I think some of the options that are already there probably shouldn't be but once you put them in, taking them out and simplifying becomes a breaking change.

Anyway, I'm merging this and I appreciate the contribution. I just wanted to put that out there.

dlvhdr commented 10 months ago

Agree. Just to add my 2 cents that I found the default icons to be tiny and hard to distinguish between them

cshuaimin commented 10 months ago

provide defaults that work really well

That's amazing, totally agree with you!

danielfalk commented 10 months ago

@dlvhdr FYI I reverted this for now (See issue #52) I can look at the fix later, but if you know what the fix is and want to resubmit, that would be great.