search

danielfarrell / bootstrap-combobox

A combobox plugin that works with twitter bootstrap
849 stars 328 forks source link

Add support for Bootstrap 4 Beta 3. #254

Closed jcass77 closed 5 years ago

jcass77 commented 6 years ago

Currently just appends a 'Show all' button to the right of the combobox (Boostrap seems to have dropped support for glyph icons.

The script still defaults to using Bootstrap version 3 as version 4 is still in beta, so the combobox needs to be initialised with $('.combobox').combobox({bsVersion: '4'}); to make use of the new HTML markup.

jcass77 commented 6 years ago

Just realised that Bootstrap already adds the 'down arrow' to the button by default, so I removed the button text.

seanVonDrake commented 6 years ago

thank you, this could really help

currently I am getting bootstrap-combobox from cdnjs, so I must wait the merge to use the {bsVersion: '4'} option, right?

hackerESQ commented 5 years ago

Works very well (see: https://codepen.io/anon/pen/PyGRvN). @danielfarrell Can we merge this with the master?

tiesont commented 5 years ago

@hackerESQ Daniel's not really active at this point. I'll see if I can find some time to review this sometime in the next few days.

thoro commented 5 years ago

it seems that the data-toggle="dropdown" should be removed, I get a popper.js exception if the data-toggle is there, if it's removed everything works as it should

Additionally the X is not displayed if the combobox is filled.