danielfernau / unifi-protect-video-downloader

Tool for downloading footage from a local UniFi Protect system
https://ui-protect-dl-docs.danielfernau.com/
MIT License
477 stars 55 forks source link

Fix and improve interval generator #380

Closed danielfernau closed 11 months ago

danielfernau commented 11 months ago

fixes #34 resolves #57 closes #376, thanks @heschlie for your suggestions!

codecov[bot] commented 11 months ago

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (6900656) 53.19% compared to head (e48b487) 56.81%.

Files Patch % Lines
protect_archiver/cli/download.py 0.00% 3 Missing :warning:
protect_archiver/downloader/download_file.py 50.00% 1 Missing :warning:
protect_archiver/sync.py 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #380 +/- ## ========================================== + Coverage 53.19% 56.81% +3.61% ========================================== Files 23 23 Lines 720 778 +58 ========================================== + Hits 383 442 +59 + Misses 337 336 -1 ``` | [Flag](https://app.codecov.io/gh/danielfernau/unifi-protect-video-downloader/pull/380/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Fernau) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/danielfernau/unifi-protect-video-downloader/pull/380/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Fernau) | `56.81% <94.11%> (+3.61%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Fernau#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.