search

danielfernau / unifi-protect-video-downloader

Tool for downloading footage from a local UniFi Protect system
https://ui-protect-dl-docs.danielfernau.com/
MIT License
473 stars 54 forks source link

Allow environment variables to be used for username and password, maybe all flags #385

Closed scelfo closed 6 months ago

scelfo commented 9 months ago

This is a small nitpick suggestion. When username and password are specified on the command line those values are visible when running simple commands like 'ps'.

This project is already using docker so it would be nice to follow a common docker pattern and allow configuration via environment variables.

danielfernau commented 8 months ago

Hi @scelfo and thanks for the suggestion. I'll look into it and let you know once the feature is available. Definitely makes a lot of sense. 👍

danielfernau commented 6 months ago

Hi @scelfo - the feature is now available for the Docker image tag edge and will be part of the upcoming v2.3.0 release. Have a look at https://github.com/danielfernau/unifi-protect-video-downloader/pull/409#issue-2128253573 or use --help in the CLI for a full list of supported environment variables. Thanks again for the suggestion and enjoy!