search

danielfernau / unifi-protect-video-downloader

Tool for downloading footage from a local UniFi Protect system
https://ui-protect-dl-docs.danielfernau.com/
MIT License
473 stars 54 forks source link

Fix downloading smart events #388

Closed nijel closed 7 months ago

nijel commented 9 months ago

It appears that the API has been again slightly changed, this works for me to download events (I don't know if motion events worked before, I don't record any).

Maybe fixes #299?

CarstenLeonhardt commented 7 months ago

@danielfernau, i have the same issue downloading events, is the a planned version with this fix ?

danielfernau commented 7 months ago

@CarstenLeonhardt, yes, sorry for the delay. This (or a similar) fix will be part of the next release. I can't promise an exact release date, though, as there are other things which require my attention at the moment. But I should be able to get it done over one of the upcoming weekends.

Thanks for your patience, everyone!

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (80e3969) 56.81% compared to head (ccffd0c) 56.81%. Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #388 +/- ## ======================================= Coverage 56.81% 56.81% ======================================= Files 23 23 Lines 778 778 ======================================= Hits 442 442 Misses 336 336 ``` | [Flag](https://app.codecov.io/gh/danielfernau/unifi-protect-video-downloader/pull/388/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Fernau) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/danielfernau/unifi-protect-video-downloader/pull/388/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Fernau) | `56.81% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Daniel+Fernau#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.