search

danielfireman / isumm

Simple and nerd way to easily summarize investiments.
GNU Affero General Public License v3.0
1 stars 3 forks source link

Add typeahead field #68

Closed brunojdo closed 8 years ago

brunojdo commented 8 years ago

It's about the issue #67

This change is Reviewable

danielfireman commented 8 years ago

Pretty awesome change!

danielfireman commented 8 years ago

As discussed online, app.html and ops.html should have something like this:

$document.ready(typeaheadOn('fieldId','hiddenFieldId', investments))

and typeahead function returns a function that uses the parameters as global variables. This reduces a lot the scope of these guys.

danielfireman commented 8 years ago

Reviewed 4 of 4 files at r1. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

brunojdo commented 8 years ago

Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions.

_static/js/typeahead.js, line 13 [r1] (raw file):_

Previously, danielfireman (Daniel Fireman) wrote… > This wiring is very fragile. I have an idea how to make this slightly better. Lets chat. >

Done.

Comments from Reviewable

danielfireman commented 8 years ago
:lgtm:

Review status: 1 of 4 files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

brunojdo commented 8 years ago

Review status: 1 of 4 files reviewed at latest revision, 1 unresolved discussion.

static/js/typeahead.js, line 7 [r1] (raw file):

Previously, danielfireman (Daniel Fireman) wrote… > Make this a constant? (Maybe JS engine does this, but I am not sure) >

Done.

Comments from Reviewable

danielfireman commented 8 years ago

Reviewed 3 of 3 files at r2. Review status: all files reviewed at latest revision, 2 unresolved discussions.

Comments from Reviewable

danielfireman commented 8 years ago

Review status: all files reviewed at latest revision, 2 unresolved discussions.

_static/js/typeahead.js, line 7 [r1] (raw file):_

Previously, brunodias20 (Bruno Dias) wrote… > Done. >

Ok

Comments from Reviewable

danielfireman commented 8 years ago

Review status: all files reviewed at latest revision, 1 unresolved discussion.

static/js/typeahead.js, line 13 [r1] (raw file):

Previously, brunodias20 (Bruno Dias) wrote… > Done. >

Ok

Comments from Reviewable