search

danielflower / multi-module-maven-release-plugin

A maven release plugin that is fast, does not add extra commits, and works well with single or multiple modules
http://danielflower.github.io/multi-module-maven-release-plugin/index.html
MIT License
125 stars 64 forks source link

https authentication #59

Closed pauldavidgilligan closed 5 years ago

pauldavidgilligan commented 7 years ago

Any thoughts on if or how we can add https authentication?

danielflower commented 7 years ago

I have thoughts, but no time to work on it.

From a user point of view, you'd want the username/password to be stored in the user's settings.xml, and referenced from the project's pom.xml by a name - much like how uploading to Nexus can be handled.

From an implementation point of view, this project uses jgit which handles HTTP authentication - wouldn't be that difficult to get it working I think.

pauldavidgilligan commented 7 years ago

yes using maven master password which is what I am doing now.

Sent from my iPad

On 9 Jul 2017, at 16:22, Daniel Flower notifications@github.com wrote:

I have thoughts, but no time to work on it.

From a user point of view, you'd want the username/password to be stored in the user's settings.xml, and referenced from the project's pom.xml by a name - much like how uploading to Nexus can be handled.

From an implementation point of view, this project uses jgit which handles HTTP authentication - wouldn't be that difficult to get it working I think.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.

xsilmarx commented 6 years ago

I'm trying to use this plugin but I get an authentication error from JGit saying "authentication is required but CredentialProvider was not registered". I'm using a server with https. I suppose this is the same issue, right?

danielflower commented 6 years ago

Yes, assuming you need a password to upload.

xsilmarx commented 6 years ago

What do you mean by "upload". I'm talking about JGit so I suppose you mean "push", is it? I'm asking just to make sure that this refers to the HTTPS authentication on Git server and not to the NEXUS authentication. If this is the case I cannot use this plugin as my Git server requires HTTPS authentication.

danielflower commented 5 years ago

HTTPS authentication was added in version 3.0.2

Please see https://danielflower.github.io/multi-module-maven-release-plugin/https-authentication.html