search

danielflower / multi-module-maven-release-plugin

A maven release plugin that is fast, does not add extra commits, and works well with single or multiple modules
http://danielflower.github.io/multi-module-maven-release-plugin/index.html
MIT License
124 stars 64 forks source link

Allow external snapshots #84

Open Marx2 opened 5 years ago

Marx2 commented 5 years ago

Hi My builds depend on springfox libraries, they're not crucial in production env, so I don't care that I use snapshots of release 3

Currently I get:

[ERROR] Cannot release with references to snapshot dependencies
[ERROR] The following dependency errors were found:
[ERROR]  * apps-service references dependency springfox-spring-webmvc ${springfox.version}

Maven release plugin support property: -DignoreSnapshots=true which allows to use snapshots dependencies during release cycle.

I would like to achieve similar behavior. Maybe (because of how MMMRP work) we can do sth different, like: -DuseSnapshot=springfox-spring-webmvc ? That settings would just use snapshot dependency of this library without touching anything about it.

Marx2 commented 5 years ago

I've tried to use -Darguments="-DignoreSnapshots=true" but it didn't help :(

danielflower commented 5 years ago

Hello, I must admit I'm not enthusiastic about allowing snapshots at all in this comment, so I don't plan to have this feature sorry.

Marx2 commented 5 years ago

It's supported by plain Maven release plugin, that's why I'm asking. On my local fork I've just commented out PomUpdater.java:122 error (replaced with just warning), and now it ignore such dependencies. I'm not 100% sure it's good method to achieve it, but it seems to work.

marcelstoer commented 5 years ago

👍 for behaving like the Maven release plugin. I see nothing wrong with disallowing snapshot dependencies by default but offering to overrule that.

kobynet commented 2 years ago

@danielflower I can create a PR for this if this is something you are going to merge eventually.