Closed phillbaker closed 7 years ago
What do you think about logging the connection failures (so they're not totally invisible)?
That would be nice, yes.
The current code should handle some concurrency - e.g. incrementing the counter at the same time or setting the opened_at timestamp at the same time, in cases where locking is done in local memory, what are your thoughts on translating that to Redis?
I think it would be nice to leverage Redis' native features to handle concurrency, as it seems you're doing already. 👍
Added logging as well - @danielfm when you get a chance another review would be great.
@danielfm any thoughts on this?
Questions:
Remaining work:
CircuitBreakerThreadsTestCase