danielfm / pybreaker

Python implementation of the Circuit Breaker pattern.
BSD 3-Clause "New" or "Revised" License
512 stars 74 forks source link

Add redis-backed storage class. #13

Closed phillbaker closed 7 years ago

phillbaker commented 7 years ago

Questions:

Remaining work:

danielfm commented 7 years ago

What do you think about logging the connection failures (so they're not totally invisible)?

That would be nice, yes.

The current code should handle some concurrency - e.g. incrementing the counter at the same time or setting the opened_at timestamp at the same time, in cases where locking is done in local memory, what are your thoughts on translating that to Redis?

I think it would be nice to leverage Redis' native features to handle concurrency, as it seems you're doing already. 👍

phillbaker commented 7 years ago

Added logging as well - @danielfm when you get a chance another review would be great.

phillbaker commented 7 years ago

@danielfm any thoughts on this?