danielfm / pybreaker

Python implementation of the Circuit Breaker pattern.
BSD 3-Clause "New" or "Revised" License
512 stars 74 forks source link

Add optional support for calling Tornado coroutines #18

Closed jeffrand closed 7 years ago

jeffrand commented 7 years ago

I'm a big fan of your library and I've been using my own fork over here at SeatGeek, so I figured I'd contribute. We use Tornado as our webserver and use this code to circuit break asynchronous code.

This change adds optional support for Tornado coroutines. This should be a backwards compatible change.

I did this by:

This also has tests that cover the parts that I added. It also fixes a bug if redis is not present.

danielfm commented 7 years ago

Totally forgot to mention this, but can you please update the README with usage instructions?

jeffrand commented 7 years ago

Will do! On Wed, Jun 21, 2017 at 5:38 PM Daniel Martins notifications@github.com wrote:

Totally forgot to mention this, but can you please update the README with usage instructions?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/danielfm/pybreaker/pull/18#issuecomment-310212722, or mute the thread https://github.com/notifications/unsubscribe-auth/ACckkW7mExmVQXIoHZ77dwnGRoWkeUkeks5sGY1HgaJpZM4N7umk .

--

  • Jeff