search

danielfm / pybreaker

Python implementation of the Circuit Breaker pattern.
BSD 3-Clause "New" or "Revised" License
512 stars 74 forks source link

Chaining exception into the CircuitBreakerError #34

Closed tczhaodachuan closed 6 years ago

tczhaodachuan commented 6 years ago

This chaining exception feature is added into Python 3.6 https://www.python.org/dev/peps/pep-3134/, however, if we used this library in Python2, the CircuitBreakerError doesn't carry the trigger exception and the trace. This maybe an issue we actually lost the trace when the threshold is breached.

danielfm commented 6 years ago

Does https://github.com/danielfm/pybreaker/pull/35 close this?

tczhaodachuan commented 6 years ago

Yes, that PR will close this issue.